Introduce galaxy_external_url variable
#18576
Conversation
Would fix galaxyproject#18572 (comment), and prevent further abuse of galaxy_infrastructure_url, with the downside that users would receive links that don't correspond to their subdomain server if they had been using one. The upside is that URLs can change, so maybe this is preferable over recording the URL for jobs/invocations/histories etc, and it seems messy to determine in what context one would like to see e.g. a job finish message.
| if job.workflow_invocation_step: | ||
| invocation_id_encoded = app.security.encode_id(job.workflow_invocation_step.workflow_invocation_id) | ||
| link_invocation = ( | ||
| f"{app.config.galaxy_infrastructure_url}/workflows/invocations/report?id={invocation_id_encoded}" |
There was a problem hiding this comment.
Hmm... well that was problematic 😨. I agree we should have this option but we should just disable this link if the config option is not set IMO. Things should just degrade well if the new option is not set and I think that means either serializing the request url with the job or dropping it all together.
| URL (with schema http/https) of the Galaxy instance as accessible | ||
| from external networks, including ``galaxy_url_prefix`` if | ||
| necessary. This URL is used to determine links outside of the web | ||
| application, e.g. when requesting job finish emails. |
There was a problem hiding this comment.
| application, e.g. when requesting job finish emails. | |
| application, e.g. when requesting job finish emails. This is complementary | |
| to `galaxy_infrastructure_url` which is for internal network use. |
| within your local network, including ``galaxy_url_prefix`` if | ||
| necessary. This URL is used as a default by pulsar file staging | ||
| and Interactive Tool containers for communicating back with Galaxy | ||
| via the API. |
There was a problem hiding this comment.
| via the API. | |
| via the API. This setting should be contrasted with `galaxy_external_url` which | |
| is for public facing services. |
There was a problem hiding this comment.
Isn't this redundant with as accessible within your local network and as accessible from external networks and the option name itself ? I think it's good to be concise here.
There was a problem hiding this comment.
Sure, maybe it can be simplified to See also: galaxy_external_url. The intent was to compare and contrast related settings, so they are not missed.
Would fix #18572 (comment),
and prevent further abuse of galaxy_infrastructure_url, with the
downside that users would receive links that don't correspond to their
subdomain server if they had been using one.
The upside is that URLs can change, so maybe this is preferable over
recording the URL for jobs/invocations/histories etc, and it seems
messy to determine in what context one would like to see e.g.
a job finish message.
How to test the changes?
(Select all options that apply)
License